⚡ Bolt: thread-safe project-aware caching for GCP Logging client - #36
⚡ Bolt: thread-safe project-aware caching for GCP Logging client#36JulienBreux wants to merge 1 commit into
Conversation
…gging client We standardise GCP client lazy-initialisation and caching across the codebase by implementing a thread-safe project-aware client caching map for GCP LogAdmin client wrappers and their default credentials reference. This avoids extremely expensive credential discovery and gRPC connection overhead (~300ms latency) on every subsequent log poll or stream request. Also make GCPClient.Close() a no-op to ensure that transient request or stream teardowns do not close and invalidate connection pools shared by concurrent log viewers in the terminal user interface. Update unit tests to maintain clean test isolation. Co-authored-by: JulienBreux <964330+JulienBreux@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This pull request introduces thread-safe project-aware caching for Google Cloud Logging (
logadmin) clients within theinternal/run/api/logpackage. Since credentials discovery and gRPC connection setup are incredibly slow (~300ms), caching clients byprojectIDavoids repeated overhead on log polling and stream requests. Additionally,GCPClient.Close()is implemented as a no-op to protect shared socket connection pools from getting closed unexpectedly during individual stream context cancellations.PR created automatically by Jules for task 3072590131917091994 started by @JulienBreux