Keep Windows trim coverage on Julia nightly - #75
Merged
Merged
Conversation
…inimal entrypoint
quinnj
changed the title
quinnj
marked this pull request as ready for review
September 21, 2026 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows Julia 1.13 can compile the trim workload successfully, then crash during executable startup. Skip only that platform/version combination, with an explicit skipped test and a note that the failure appears fixed in Julia 1.14 nightly. Other package tests still run on Windows 1.13.
Add an explicit Windows nightly job to normal CI and allow it to run the trim workload despite its prerelease version. Nightly failures remain blocking. The temporary diagnostic workflow and script are removed from the final diff.
The controlled comparison reproduced the original crash in both 1.13.0 jobs. Both nightly jobs passed all original trim assertions and 1,080 comparison launches on Julia
1.14.0-DEV.3314(8b8d4e94f0). That build includes Julia #62407, but the test does not isolate it from other upstream changes.Validation at
48a0b89d0ced1069e3ad4efa3b966be03e287bbd: all nine CI checks passed. Windows Julia 1.13.0 reports the intended trim skip. Windows nightly1.14.0-DEV.3315(91c1245ddf) compiled and executed the workload and passed all seven trim checks. Local Julia syntax parsing andgit diff --checkalso passed.Co-authored by Codex