Preserve message bodies during verbose logging - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
verbose=true, MCP logs convert response byte vectors withString(response.body). That operation takes ownership of the vector and empties it. Discovery then parses an empty manifest, and JSON-RPC calls can fail with an empty-response error. The request logging helper has the same ownership problem for byte-vector input.Preserve bytes in the shared logging conversion and reuse it for response and discovery logs. Add 18 checks for vector/view/code-unit ownership and real verbose HTTP discovery, initialization, ping, and tool listing.
Validation: the response-buffer reproduction fails on main. Full suites pass on Julia 1.12.6 with HTTP 2 and on Julia 1.10.11 with HTTP 1 explicitly selected. Julia 1.12 trim compilation/execution and the required documentation build/doctests pass.
Co-authored by Codex