Handle valid authentication challenge parameters and tokens - #12
Merged
Merged
Conversation
quinnj
changed the title
quinnj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authentication challenges could lose resource metadata and scopes with whitespace before
=or mixed-case parameter names. The parser also treated a padded token such asNegotiate abc==as a parameter instead of a token.Handle parameter whitespace, token68 padding, and case-insensitive parameter names. Preserve parameter value case. Keep the local parser so MCP's existing HTTP/OAuth dependency choices remain supported. The grammar is defined in RFC 9110 section 11.3.
Validation: 84 added parser/challenge assertions, including whitespace, quoted/unquoted metadata, scopes, multiple schemes, padded tokens, and mixed-case names and values. Full Julia 1.10.11 and 1.12.6 suites passed, including real HTTP discovery and the Julia 1.12 trimmed executable (7 trim assertions). The required documentation build and doctests also passed.
Co-authored by Codex