Convert VecSeq lengths to the library's PetscInt - #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VecSeq(petsclib, 10)returnsnothingon any library whosePetscIntisn't the platformInt, then fails at the finalizer with "objects of type Nothing cannot be finalized". The length was typed::Intand handed straight to the ccall, so it missed the generated method and landed on the empty stub atVec_wrappers.jl:4989. Same for thecomm, x::Vectormethod.The array constructor just above already converts through
petsclib.PetscInt, so these do too now. Hit it withgetlib(PetscScalar=Float64, PetscInt=Int32), or on 32-bit Julia whereIntisInt32. The case added to the VecSeq testset errors without the fix.