build: ship REVIEW_NOTE.txt in the source archive - #224
Merged
Conversation
A reviewer who only has the two uploaded files (XPI and source archive) otherwise never sees the permission rationale or the build and verify instructions — the note lived in the repository only. It is a non-shipped file, so it joins EXTRA_FILES rather than the XPI file list; the XPI itself is unchanged and still builds to the same hash. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviewer note lived in the repository only, so a reviewer who has just the two uploaded files (XPI and source archive) never saw the permission rationale or the build and verify instructions.
It is not a shipped file, so it joins
EXTRA_FILESinscripts/build-source-zip.mjsrather than the XPI file list. The XPI is untouched and still builds tofdf9c45f…; only the source archive gains one file (67 → 68).Verified: rebuilding the XPI from the new archive reproduces the released hash exactly.