JSON.Object doesn't support `pop!()`

[hhaensel]

Is there a reason that JSON.Object doesn't support pop!().

(Or more generally, why isn't pop!() defined for AbstractDicts, whereas push!()is ... But that's nothing we can change here.)

[hhaensel]

along the lines (AI-assisted)

function pop!(obj::JSON.Object{K,V}, key::K) where {K,V}
    ch = JSON._ch(obj)
    ch === JSON.notset && throw(KeyError(key))  # empty object

    parent = obj
    node = ch
    while true
        if JSON._k(node) !== JSON.notset && isequal(JSON._k(node)::K, key)
            v = JSON._v(node)::V
            # splice node out: parent's child becomes node's child
            nch = JSON._ch(node)
            setfield!(parent, :child, nch === JSON.notset ? JSON.notset : nch)
            return v
        end
        nxt = JSON._ch(node)
        nxt === JSON.notset && throw(KeyError(key))
        parent = node
        node = nxt::JSON.Object{K,V}
    end
end

function pop!(obj::JSON.Object{K,V}, key::K, default) where {K,V}
    ch = JSON._ch(obj)
    ch === JSON.notset && return default  # empty object

    parent = obj
    node = ch
    while true
        if JSON._k(node) !== JSON.notset && isequal(JSON._k(node)::K, key)
            v = JSON._v(node)::V
            nch = JSON._ch(node)
            setfield!(parent, :child, nch === JSON.notset ? JSON.notset : nch)
            return v
        end
        nxt = JSON._ch(node)
        nxt === JSON.notset && return default
        parent = node
        node = nxt::JSON.Object{K,V}
    end
end

Base.pop!(obj::JSON.Object{String}, key::Symbol) = pop!(obj, String(key))
Base.pop!(obj::JSON.Object{Symbol}, key::String) = pop!(obj, Symbol(key))
Base.pop!(obj::JSON.Object{String}, key::Symbol, default) = pop!(obj, String(key), default)
Base.pop!(obj::JSON.Object{Symbol}, key::String, default) = pop!(obj, Symbol(key), default)

[hhaensel]

It would be nice to also add pop!(d) and popfirst! and pushfirst!

[hhaensel]

I can prepare a PR if that's interesting