Skip to content

jetls fixes - #99

Merged
hexaeder merged 1 commit into
JuliaGraphs:masterfrom
BjarkeHautop:jetls-fixes
Aug 5, 2026
Merged

jetls fixes#99
hexaeder merged 1 commit into
JuliaGraphs:masterfrom
BjarkeHautop:jetls-fixes

Conversation

@BjarkeHautop

Copy link
Copy Markdown
Contributor

Various fixes for issues found by jetls, such as

  • using isnothing over == nothing.
  • explicit === over , since can return missing, whereas === on Symbols always returns a Bool.
  • @addcall generated align(g; kwargs...) = layout(Align(; kwargs...), g), but Align has no all-keyword constructor.
  • SquareGrid skip-list check now uses a Set instead of Vector, avoiding the same missing-prone .
  • Stress uses any(isinf, distances) instead of any(isequal(typemax(FT)), distances).
  • replaced for i in 1:length(x)/1:size(x, 1) loops with eachindex/axes.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (0bfd2ed) to head (6ad1e2f).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   97.40%   97.41%           
=======================================
  Files          10       10           
  Lines         579      580    +1     
=======================================
+ Hits          564      565    +1     
  Misses         15       15           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hexaeder
hexaeder merged commit 073192a into JuliaGraphs:master Aug 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants