Implement Sugiyama - #100
Open
BjarkeHautop wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 97.40% 97.47% +0.06%
==========================================
Files 10 16 +6
Lines 579 1384 +805
==========================================
+ Hits 564 1349 +785
- Misses 15 35 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Sugiyama layout based on the Rust implementation https://github.com/paddison/rust-sugiyama. Also ports several fixture tests to
verify they give the same output as the source.
The algorithm needs to mutate the graph, so added the needed graph operations to Sugiyama.
Also fixed a bug in the reference implementation:
mark_type_1_conflictsruns before vertex positions are populated there, so its conflict detection is
a no-op, see paddison/rust-sugiyama#26 and paddison/rust-sugiyama#27.
Generated with the help of Claude Code, and manually modified and verified.
Fixes #20