Stop excluding device code from coverage - #641
Merged
Merged
Conversation
GPUCompiler now records line coverage of device code when compiling it (JuliaGPU/GPUCompiler.jl#844, in every 2.x release), so kernels no longer show up as uncovered. Drop the COV_EXCL markers around device code and the src/device codecov ignore, so reports show which device code the tests actually compile. Markers around host code that tests can't reach, like the error description tables, stay.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 81.53% 80.59% -0.95%
==========================================
Files 50 54 +4
Lines 3607 3854 +247
==========================================
+ Hits 2941 3106 +165
- Misses 666 748 +82 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPUCompiler now records line coverage of device code when compiling it (JuliaGPU/GPUCompiler.jl#844, in every 2.x release), so kernels no longer show up as uncovered. This PR drops the
COV_EXCLmarkers around device code and thesrc/devicecodecov ignore, so reports show which device code the tests actually compile. Markers around host code that tests can't reach, like the error description tables, stay.I checked this with Metal.jl on Julia 1.10 and 1.12 under
--code-coverage: kernel bodies (reduce_warp,broadcast_linear, the scan kernels, ...) show up as covered, and device code that isn't compiled, like the non-shufflereduce_groupfallback, stays uncovered.