Remove a quirk that never applies - #638
Merged
Merged
Conversation
Base.Checked.throw_overflowerr_negation takes a single argument on every supported version of Julia, so the three-argument override never matched.
This was referenced Sep 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 81.53% 81.64% +0.11%
==========================================
Files 50 50
Lines 3607 3607
==========================================
+ Hits 2941 2945 +4
+ Misses 666 662 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base.Checked.throw_overflowerr_negationtakes a single argument on every supported version of Julia (1.10 through nightly), so the three-argument override inquirks.jlnever matched. Found by checking the signature of every method in the overlay method table against the methods in Base; this was the only one that doesn't match anything. The same dead override exists in the other back-ends, which get the same fix.