Skip to content

Remove a quirk that never applies - #638

Merged
maleadt merged 2 commits into
mainfrom
tb/dead-quirks
Sep 23, 2026
Merged

maleadt merged 2 commits into
mainfrom
tb/dead-quirks

Conversation

@maleadt

@maleadt maleadt commented Sep 23, 2026

Copy link
Copy Markdown
Member

Base.Checked.throw_overflowerr_negation takes a single argument on every supported version of Julia (1.10 through nightly), so the three-argument override in quirks.jl never matched. Found by checking the signature of every method in the overlay method table against the methods in Base; this was the only one that doesn't match anything. The same dead override exists in the other back-ends, which get the same fix.

Base.Checked.throw_overflowerr_negation takes a single argument on every
supported version of Julia, so the three-argument override never matched.
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.64%. Comparing base (d2e06ce) to head (9faa426).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   81.53%   81.64%   +0.11%     
==========================================
  Files          50       50              
  Lines        3607     3607              
==========================================
+ Hits         2941     2945       +4     
+ Misses        666      662       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt
maleadt merged commit af6e20e into main Sep 23, 2026
4 of 5 checks passed
@maleadt
maleadt deleted the tb/dead-quirks branch September 23, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant