Repository navigation
Conversation
Contributor
Metal.jl BenchmarksDetails
This comment was automatically generated by workflow using github-action-benchmark. |
maleadt
force-pushed
the
tb/gpuarrays-12
branch
from
October 7, 2026 19:19
484c6c9 to
0d8b58c
Compare
GPUArrays 12 implements these for every GPU array on AcceleratedKernels and no longer calls the mapreducedim! hook. Delete Metal's reduction kernels, its MPSGraph reductions (GPUArrays 12 has no hook for vendor reductions), the native scan, findall and logical indexing. MPSGraph stays the fast path for sorting and scans, with everything else handed to GPUArrays' methods instead of Base's scalar ones. Sorting now accepts AcceleratedKernels' algorithms, and sortperm is stable by default, as in Base: MPSGraph's argsort is only used when the algorithm allows an unstable result.
maleadt
force-pushed
the
tb/gpuarrays-12
branch
from
October 7, 2026 19:59
0d8b58c to
e3c5a11
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports Metal.jl to GPUArrays 12, which implements Base's reductions, sorting, scans,
findall, logical indexing andreverseonce for every GPU array, on AcceleratedKernels 0.5 (JuliaGPU/GPUArrays.jl#790), and removes theGPUArrays.mapreducedim!hook.Metal.reduce_alg). GPUArrays 12 has no hook for vendor reductions; one can come in a 12.x minor if benchmarks show MPSGraph is worth it.findalland logical indexing.Metal.scan_alg); everything else goes to GPUArrays' methods instead of Base's scalar ones. Sorting now accepts AcceleratedKernels' algorithms, andsortpermis stable by default, as in Base: MPSGraph's argsort is only used when the algorithm allows an unstable result.Intended as a minor release. Supersedes #874 (simd shuffles in the native scan, which is gone).