CI: test the back ends' ka-0.10 branches - #819
Merged
Merged
Conversation
Contributor
Benchmark ResultsShow table
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Member
Author
|
oneAPI.jl and AMDGPU.jl failure expected since they rely on AK.jl. That move requires a GPUArrays.jl break. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
+ Coverage 70.04% 70.46% +0.41%
==========================================
Files 27 27
Lines 2207 2194 -13
==========================================
Hits 1546 1546
+ Misses 661 648 -13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Buildkite jobs that run the GPU back ends' KernelAbstractions and KernelInterface tests still install the old port branches (
intrinsics,kaintr, and Christian's forks for oneAPI and AMDGPU). Those require KernelInterface 0.2/0.3, so none of them installs against main anymore: every back-end job exits with status 3 and soft-fails, and nothing tests the back ends against KA main.This points the jobs at the
ka-0.10branches, where each back end implements KernelInterface 0.4 and ports its KA layer to the generic launch: JuliaGPU/CUDA.jl#3314, JuliaGPU/Metal.jl#994, JuliaGPU/oneAPI.jl#653, JuliaGPU/AMDGPU.jl#1117 and JuliaGPU/OpenCL.jl#519.Every job should now install. A job that still soft-fails with exit status 3 means that branch's compat or
[sources]is wrong. oneAPI and AMDGPU are expected to keep failing until they drop their AcceleratedKernels dependency, which currently doesn't allow KA 0.10.