Repository navigation
Conversation
GemmKernels uses no LLVM.jl API besides LLVM.Interop's unsafe_load and unsafe_store! methods on Core.LLVMPtr (in the vectorized loads and stores of the Layout module), which are unchanged in LLVM.jl 10. The `using LLVM` in the Operator module was unused; move the import to the Layout module, which is what depends on it. unsafe_store! on a Core.LLVMPtr now returns the pointer instead of nothing, which vstorea! passes on but no caller uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows LLVM.jl 10. GemmKernels only uses
LLVM.Interop'sunsafe_loadandunsafe_store!onCore.LLVMPtr, which LLVM.jl 10 keeps.using LLVMmoves fromOperator, where it was unused, toLayout, which needs it.Tested with CUDA.jl on LLVM.jl 10: the full suite on Julia 1.12 and a subset on 1.11 give the same results as before.
Requires a CUDA.jl release with LLVM.jl 10 support (JuliaGPU/CUDA.jl#3323).
Disclaimer: this PR is AI-assisted and has not been reviewed in detail. Tests pass locally, so it should be a good starting point for a maintainer to complete the upgrade.