Skip to content

Test for closure boxes on Julia 1.14+ #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Oct 15, 2026
Merged

Test for closure boxes on Julia 1.14+ #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using ParallelTestRunner: runtests, parse_args
using Test
import GPUArrays

include("testsuite.jl")
Expand All @@ -25,4 +26,12 @@ for AT in (:JLArray, :Array), name in keys(TestSuite.tests)
testsuite["$(AT)/$name"] = :(TestSuite.tests[$name]($AT))
end

# captured variables that get boxed (`Core.Box`) lose their type
if isdefined(Test, :detect_closure_boxes)
testsuite["closure boxes"] = quote
import GPUArrays
@test Test.detect_closure_boxes(GPUArrays, GPUArrays.GPUArraysCore, JLArrays) == []
end
end

runtests(GPUArrays, args; init_code, init_worker_code, testsuite)
6 changes: 3 additions & 3 deletions test/testsuite.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ function exact_result(@nospecialize(f), @nospecialize(xs...))
catch err
return typeof(err)
end
exact(x::AbstractArray) = (eltype(x), size(x), collect(x))
exact(x::Tuple) = map(exact, x)
exact(x) = (typeof(x), x)
return exact(r)
end
exact(x::AbstractArray) = (eltype(x), size(x), collect(x))
exact(x::Tuple) = map(exact, x)
exact(x) = (typeof(x), x)
compare_exact(@nospecialize(f), AT::Type{<:AbstractGPUArray}, @nospecialize(xs...)) =
isequal(exact_result(f, map(deepcopy, xs)...),
exact_result(f, map(x -> x isa AbstractArray ? adapt(AT, x) : x, xs)...))
Expand Down
2 changes: 1 addition & 1 deletion test/testsuite/alloc_cache.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
end
@test sizeof(cache) == sizeof(cached4) + sizeof(cached5)
_keys = collect(keys(cache.free))
key2 = _keys[findfirst(i -> i != key, _keys)]
key2 = _keys[findfirst(!=(key), _keys)]
@test length(cache.free[key]) == 1
@test length(cache.free[key2]) == 1
@test cache.free[key2][1] === GPUArrays.storage(cached5)
Expand Down
Loading