Repository navigation
Conversation
Julia 1.10's Base.mightalias does not check for empty arrays, which later versions do. GPU back-ends like AMDGPU give every empty array the same null data pointer, so reductions, scans and workspaces rejected empty destinations and sources as aliasing (GPUArrays' testsuite on AMDGPU with Julia 1.10).
Member
Author
|
Superseded: the problem is AMDGPU's pointer-based |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia 1.10's
Base.mightaliasdoesn't check for empty arrays; 1.11 and later do. GPU back-ends like AMDGPU give every empty array the same null data pointer, so on Julia 1.10 reductions, scans and workspace checks rejected empty destinations and sources as aliasing. This caused 221 errors in AMDGPU's GPUArrays testsuite on 1.10, e.g.cumsum(ROCArray(Int[]))andsum(A; dims=2)for a 0×3A.Uses an
isempty-guarded_mightaliasat the three call sites. The tests use reshaped empty views, which reproduce the false positive on CPU arrays on Julia 1.10.Bumps the version to 0.5.3.