don't report coverage from 1.10 - #85
Draft
simeonschaub wants to merge 1 commit into
Draft
Conversation
Julia 1.10 marks the signature line of every `@stable` function as uncovered: `@stable` generates a simulator method next to the real one, whose body carries the source lines of the original, and 1.10 gives that method a coverage slot on its signature line even though it is only ever inferred, never run. Julia 1.12 stops emitting the slot, but Codecov merges the uploads, so a zero coming from 1.10 buries the line the newer report leaves alone. Reproduces in a 15-line package: `@stable function f(x); return x + 1; end`, called once, reports 0 on the `function` line under 1.10 and nothing under 1.12. Disabling DispatchDoctor makes 1.10 agree. The lts jobs keep running the tests, they just stop instrumenting them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
simeonschaub
marked this pull request as draft
August 3, 2026 15:56
Collaborator
Author
|
Hmm, not sure this is the right fix looking at the codecov report. I'll look into whether this can perhaps be fixed in DispatchDoctor instead |
Member
Collaborator
Author
|
Ah, it's closed so I missed that one, thanks for the link! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DispatchDoctor's
@stablemacro doesn't play well together with code coverage in Julia 1.10, causing lines to show up in the coverage report that can never be hit. Work around that by only reporting coverage for the latest Julia release.