Preserve both subtrees when merging mt_backedges - #474
Merged
Merged
Conversation
`join_invalidations!` keeps the node already present in `list`, so `join_branches!` must merge the incoming node into that one. Merging in the opposite direction discarded the incoming callers, so `invalidation_trees` omitted invalidations that `consolidate=false` reported. In the `:deleting` consolidation loop, `covered` now resets per edge, and the edge is wrapped in a `BackedgeMT` vector to match `join_invalidations!`. Fixes #364 Assisted-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
join_invalidations!keeps the node already present inlist, sojoin_branches!must merge the incoming node into that one. Merging in the opposite direction discarded the incoming callers, soinvalidation_treesomitted invalidations thatconsolidate=falsereported.In the
:deletingconsolidation loop,coverednow resets per edge, and the edge is wrapped in aBackedgeMTvector to matchjoin_invalidations!.Fixes #364
Assisted-by: Claude Opus 5 noreply@anthropic.com