Recover the parent of a frame in a recursive cycle - #473
Merged
Merged
Conversation
When inference resolves a cycle of mutually-recursive calls, the call that closes the cycle is absent from the caller's `CodeInstance` edges and is recorded only in the callee's `MethodInstance` backedges. A frame reachable only through that call therefore looked like an entrance to inference and became a direct child of `ROOT`, where its missing backtrace made `inference_triggers` throw. Consult the `MethodInstance` backedges for any frame that has neither a caller nor a backtrace, and follow the recovered link when building the tree. Resolving the top of a chain of callers now tolerates cycles, which the recovered links can introduce. Fixes #456 Assisted-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inference resolves a cycle of mutually-recursive calls, the call that closes the cycle is absent from the caller's
CodeInstanceedges and is recorded only in the callee'sMethodInstancebackedges. A frame reachable only through that call therefore looked like an entrance to inference and became a direct child ofROOT, where its missing backtrace madeinference_triggersthrow.Consult the
MethodInstancebackedges for any frame that has neither a caller nor a backtrace, and follow the recovered link when building the tree. Resolving the top of a chain of callers now tolerates cycles, which the recovered links can introduce.Fixes #456
Assisted-by: Claude Opus 5 noreply@anthropic.com