Skip to content

Make get_effects and get_exct shared generics - #707

Merged
serenity4 merged 1 commit into
JuliaDebug:masterfrom
jishnub:share-effects-exct-generics
Aug 22, 2026
Merged

serenity4 merged 1 commit into
JuliaDebug:masterfrom
jishnub:share-effects-exct-generics

Conversation

@jishnub

@jishnub jishnub commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

src/CthulhuCompiler.jl imports the CallInfo accessors from Cthulhu so that both compiler integrations extend the same generic functions — but get_effects and get_exct are missing from that import list, and get_effects is instead defined fresh at the bottom of the file.

Since CthulhuCompiler.jl is included once into Cthulhu and again into CthulhuCompilerExt when Compiler.AbstractInterpreter !== Base.Compiler.AbstractInterpreter, this means Cthulhu.get_effects and CthulhuCompilerExt.get_effects become two distinct functions in that configuration, and Cthulhu.get_effects(info) raises a MethodError for any CallInfo produced by the extension. get_ci, get_rt and the rest are unaffected because they are imported.

This adds function get_effects end / function get_exct end next to the existing stubs in callsite.jl (they had no owning declaration before) and adds both names to the import list.

No behaviour change in the common case, where Compiler reexports Base.Compiler and the extension is a no-op.

🤖 Generated with Claude Code

Declare them alongside the other `CallInfo` accessor stubs in callsite.jl and
import them in CthulhuCompiler.jl, so Cthulhu and CthulhuCompilerExt extend one
generic function rather than defining two.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (2c33b9a) to head (28f0c59).
⚠️ Report is 99 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #707    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files           9      22    +13     
  Lines        1556    1808   +252     
=======================================
- Misses       1556    1808   +252     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serenity4

Copy link
Copy Markdown
Collaborator

Makes sense, thanks!

@serenity4
serenity4 merged commit 0155b1f into JuliaDebug:master Aug 22, 2026
9 of 13 checks passed
@jishnub
jishnub deleted the share-effects-exct-generics branch August 22, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants