Skip to content

Scan multiple rows for determining type in strict mode#349

Open
evetion wants to merge 1 commit intoJuliaDatabases:masterfrom
evetion:feat/typescan
Open

Scan multiple rows for determining type in strict mode#349
evetion wants to merge 1 commit intoJuliaDatabases:masterfrom
evetion:feat/typescan

Conversation

@evetion
Copy link
Copy Markdown
Contributor

@evetion evetion commented May 4, 2026

Alternative to #348.

Instead of trying to find a good default type for when the first row is NULL in strict mode, this PR scans the whole column until it finds a non-NULL value and uses that to derive the type. This not only fixes the issue described in #348, but also the downside of #346 that would corrupt Julia types in strict mode for columns starting with NULL (i.e. a symbol becoming a string).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.25%. Comparing base (95131f8) to head (f9624b9).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/SQLite.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   94.13%   93.25%   -0.89%     
==========================================
  Files           4        4              
  Lines         563      623      +60     
==========================================
+ Hits          530      581      +51     
- Misses         33       42       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@visr
Copy link
Copy Markdown
Contributor

visr commented May 4, 2026

Thanks, yes this seems better to me than #348.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants