Scan multiple rows for determining type in strict mode#349
Open
evetion wants to merge 1 commit intoJuliaDatabases:masterfrom
Open
Scan multiple rows for determining type in strict mode#349evetion wants to merge 1 commit intoJuliaDatabases:masterfrom
evetion wants to merge 1 commit intoJuliaDatabases:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
==========================================
- Coverage 94.13% 93.25% -0.89%
==========================================
Files 4 4
Lines 563 623 +60
==========================================
+ Hits 530 581 +51
- Misses 33 42 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks, yes this seems better to me than #348. |
visr
added a commit
to Deltares/Ribasim
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #348.
Instead of trying to find a good default type for when the first row is NULL in strict mode, this PR scans the whole column until it finds a non-NULL value and uses that to derive the type. This not only fixes the issue described in #348, but also the downside of #346 that would corrupt Julia types in strict mode for columns starting with NULL (i.e. a symbol becoming a string).