Enable the writing of nanosecond units for time axes. - #582
Draft
felixcremer wants to merge 1 commit into
Draft
Conversation
This is currently still broken because CFTime.units is not defined for Dates.DateTime types.
felixcremer
marked this pull request as draft
March 25, 2026 17:01
Member
Author
|
We should make the cftime storage units a metadata field for the lookup when we read the data so that we can then change to the same units while writing. This would need changes to the reading of data but then the writing is not dependent on the changes in CFTime anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently still broken because CFTime.units is not defined for Dates.DateTime types.
I am not sure, whether this is something that should be fixed here or in CFTime.