Skip to content

Generalized save#347

Open
Qfl3x wants to merge 1 commit into
JuliaDataCubes:mainfrom
Qfl3x:unified-save
Open

Generalized save#347
Qfl3x wants to merge 1 commit into
JuliaDataCubes:mainfrom
Qfl3x:unified-save

Conversation

@Qfl3x

@Qfl3x Qfl3x commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

#309

Still needs some docs

@codecov

codecov Bot commented Oct 19, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.61%. Comparing base (ee64a86) to head (8aa1edc).
⚠️ Report is 330 commits behind head on main.

Files with missing lines Patch % Lines
src/DatasetAPI/Datasets.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   69.74%   69.61%   -0.13%     
==========================================
  Files          12       12              
  Lines        1702     1774      +72     
==========================================
+ Hits         1187     1235      +48     
- Misses        515      539      +24     
Files with missing lines Coverage Δ
src/DatasetAPI/Datasets.jl 75.97% <0.00%> (-1.07%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lazarusA

Copy link
Copy Markdown
Collaborator

more importantly doc strings and tests 😄 . But, I would like to have the opinion of @meggart on this?

@lazarusA
lazarusA requested a review from meggart October 19, 2023 09:42

@meggart meggart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, yes its a good idea to merge the 2. However, it would be good to be consequent and just deprecate savecube and savedataset (see the docs of the @deprecate macro) so that we can entirely remove them in future YAXArray versions.

@lazarusA lazarusA added the help wanted Extra attention is needed label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants