CI: pass --check-bounds=auto to the default-bounds job - #150
Merged
Merged
Conversation
julia-runtest has no `julia_args` input: the runner warned and the action ignored it, so the job ran with --check-bounds=yes like the others since it was added, and the noshift span reconstruction it exists to test never ran in CI. `check_bounds: 'auto'` is the input the action declares. The suite passes under it locally with coverage off. Assisted-by: Claude (Anthropic)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 15 15
Lines 2649 2649
=======================================
Hits 2561 2561
Misses 88 88 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "default-bounds allocation guards" job passes
julia_args: '--check-bounds=auto'tojulia-actions/julia-runtest@v1, an input the action does not declare. The runner has annotated every run with "Unexpected input(s) 'julia_args'" since the job was added in ec271f9, and the action ignored the value. The job ran with--check-bounds=yeslike the others, so the noshift span reconstruction it exists to test never ran in CI.check_bounds: 'auto'is the declared input; the action turns it into--check-bounds=autoon thePkg.testcommand. The suite passes under that flag locally with coverage off, 4610 tests.