Skip to content

refactor: Split out lz4f from lz4 + upstream to ChunkCodecs.jl - #73

Draft
icweaver wants to merge 4 commits into
mainfrom
split-lz4-lz4f
Draft

icweaver wants to merge 4 commits into
mainfrom
split-lz4-lz4f

Conversation

@icweaver

@icweaver icweaver commented Aug 28, 2026 •

Copy link
Copy Markdown
Member

Todo:

  • Split out lz4f from lz4

  • Simplify with a TBD codec upstreaming our hand-rolled decode_Lz4 and friends to ChunkCodecLibLz4.jl, addresses the following TODO

    ASDF.jl/src/ASDF.jl

    Lines 286 to 290 in 7fcfb77

    elseif compression == C_Lz4
    # TODO: Once an `LZ4ASDFCodec` is upstreamed to ChunkCodecs.jl,
    # this could be added to the uniform codec branches below.
    # https://github.com/JuliaAstro/ASDF.jl/issues/72
    data = decode_Lz4(data, Int(header.data_size))

@icweaver icweaver linked an issue Aug 28, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cfbde37) to head (039fac6).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          589       580    -9     
=========================================
- Hits           589       580    -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding LZ4ASDF format to ChunkCodecLibLz4?

1 participant