MIT Demo App Fixes - #359
Merged
RafalOzogJudopay merged 2 commits intoAug 17, 2026
Merged
Conversation
Google Pay validation fails when optional values come from Demo App as empty strings, they should come as nulls as SDK expects. Otherwise there is no way of passing null value from the Demo app.
Proguard removes references to classes that are used only exclusively in the prefrences XML, as in this case. It was causing crash due to "ClassNotFoundException: com.judokit.android.examples.settings.fragments.GooglePaySettingsFragment".
RafalOzogJudopay
changed the title
|
eugenezhernakov
approved these changes
Aug 17, 2026
stefan-tudor
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Pay validation fails when optional values come from Demo App as empty strings. They are expected to come as nulls.
Now it passes empty Google Pay properties as null if it's just empty editText, not as empty string.
PS: Simple removal of default values from google_pay_preferences.xml wasn't enough, because whenever user opens it and saves (as an empty value), then it is automatically saved as empty string.