feat: Add crossAxisAlignment management#6
Open
taorepoara wants to merge 2 commits into
Open
Conversation
Jozott00
requested changes
Mar 22, 2026
Owner
Jozott00
left a comment
Jozott00
left a comment
There was a problem hiding this comment.
Hi, thanks a lot for the PR!
Looks very good overall. Once the CrossAxisAlignment.baseline issue is fixed, this should be ready to merge.
Comment on lines
+334
to
+335
| // TODO: Handle this case. | ||
| CrossAxisAlignment.baseline => throw UnimplementedError(), |
Owner
There was a problem hiding this comment.
Please implement this, or explicitly reject it in the constructor to make clear the CrossAxisAlignment.baseline is currently not supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the crossAxisAlignement based on the @bwillner implementation.
I also added some basic unit tests in order to avoid braking existing behavior during the implementation.