Replace Makefiles with justfiles for improved task automation - #12
Closed
JoeyBF wants to merge 1 commit into
Closed
Conversation
Convert the three Makefiles (ext, web_ext/sseq_gui, web_ext/steenrod_calculator) to justfiles and update every caller. - ext/justfile: benchmark pattern rules become parametrized recipes (bench/bench-concurrent/fix-bench NAME) plus loop recipes over examples/benchmarks/*. The benchmark first line is expanded unquoted into an inner `bash -c`, reproducing the Makefile's quote-removal of the literal "" tokens. Also fixes the long-standing fix-benchmarks bug (bare BENCHMARKS instead of $(BENCHMARKS)). - web_ext/sseq_gui/justfile: WASM_UNWIND becomes a justfile variable (override via `just WASM_UNWIND=1 wasm`) driving if/else flag vars; test-wasm-unwind re-invokes the lib build with the override. - CI (.github/workflows/ext.yaml): swap `make -C <dir> <tgt>` for `just --working-directory <dir> --justfile <dir>/justfile <tgt>` and add an extractions/setup-just step to every job that runs recipes. - Nix: add pkgs.just to the root flake's devTools (subflakes inherit it) and swap make->just in the ext/sseq_gui app run scripts. - READMEs: update documented commands. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DSAx1G1eMeCYPwNH7WNMVo
Owner
Author
|
Closing in favor of the upstream PR: SpectralSequences#255. The same branch ( Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the project's Makefiles with justfiles, a more modern and maintainable task runner. The
justcommand provides better syntax, improved variable handling, and more intuitive recipe definitions compared to Make.Summary of Changes
ext/justfile,web_ext/sseq_gui/justfile, andweb_ext/steenrod_calculator/justfileto replace their corresponding Makefilesext/Makefile,web_ext/sseq_gui/Makefile, andweb_ext/steenrod_calculator/Makefile.github/workflows/ext.yamlto usejustcommands instead ofmake, including setup of thejusttool (v1.34)justcommands instead ofmakepkgs.justtoflake.nixfor Nix usersKey Implementation Details
{{VAR}}instead of$(VAR)) and more readable recipe definitionsjust's if/else expressions for cleaner conditional builds (e.g., WASM_UNWIND handling)justv1.34 and usejust --working-directoryto run commands from appropriate directoriesThe migration maintains all existing build targets and test commands while providing a more maintainable and user-friendly interface for developers.
https://claude.ai/code/session_01DSAx1G1eMeCYPwNH7WNMVo