Skip to content

Remove some non-determinism#554

Open
licaon-kter wants to merge 1 commit into
Jigsaw-Code:masterfrom
licaon-kter:patch-1
Open

Remove some non-determinism#554
licaon-kter wants to merge 1 commit into
Jigsaw-Code:masterfrom
licaon-kter:patch-1

Conversation

@licaon-kter

Copy link
Copy Markdown

Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro

Looking at the latest app report: https://verification.f-droid.org/packages/app.intra/

We can fix the GO BUILDID and the different /tmp paths.

Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro

Looking at the latest app report: https://verification.f-droid.org/packages/app.intra/

We can fix the GO BUILDID and the different /tmp paths.
@google-cla

google-cla Bot commented May 27, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@licaon-kter

Copy link
Copy Markdown
Author

Haha CLA, no, but you can take this as you please 😉

@jyyi1

jyyi1 commented May 27, 2025

Copy link
Copy Markdown
Contributor

Thanks for the contribution. But unfortunately this PR won't make the app reproducible. Because to ensure a reproducible build, we need to use a fixed version of gomobile, but they only officially provide the latest 0.0.0 version. This means that even if we fix the BUILDID, the produced binary isn't guaranteed to be reproducible.

@licaon-kter

Copy link
Copy Markdown
Author

True, but I've tested this, and as the title says it's about "some" of it. :)

Could this be made perfect? I hope so, in the mean time, this PR improves things.

@jyyi1 jyyi1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That sounds reasonable to me. Please accept the CLA so we can merge the PR.

@licaon-kter

Copy link
Copy Markdown
Author

As said, I won't submit to any CLA. :)

@ignoramous

Copy link
Copy Markdown
Contributor

... to ensure a reproducible build, we need to use a fixed version of gomobile, but they only officially provide ... 0.0.0 ...

Also, gomobile driven builds don't yet respect -trimpath, at least not from what we've observed (from build of our Intra fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants