(cmake) Added ability to override JSL_PLATFORM_DEPENDENCY_VISIBILITY with user provided value - #71
Open
Patrix9999 wants to merge 1 commit into
Open
(cmake) Added ability to override JSL_PLATFORM_DEPENDENCY_VISIBILITY with user provided value#71Patrix9999 wants to merge 1 commit into
JSL_PLATFORM_DEPENDENCY_VISIBILITY with user provided value#71Patrix9999 wants to merge 1 commit into
Conversation
…` with user provided value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is simple, right now when we compile the library as
static, theJSL_Platform::Dependenciesare being directly exposed to thecmake projectthat usestarget_link_librariesto link againstJoyShockLibrary.This is a problem, because in my specific scenario i don't want my project to use
WIN32_LEAN_AND_MEANor_UNICODEmacros (they should remain hidden inside the dependency).With this change, the user can override
JSL_PLATFORM_DEPENDENCY_VISIBILITYwith it's own custom value.