refactor(calculate): extract safe percentage rounding logic into a single reusable helper function#6155
Open
ChetanSenta wants to merge 1 commit into
Conversation
…gic into a dedicated safe utility
Contributor
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6148
Pillar
Visual Preview
Zero behavioral or visual outcome changes. All computed statistical outputs remain identical to previous calculations.
What this PR does
Cleans up redundant, duplicated code patterns in
lib/calculate.ts. The codebase contained several identical inline ternary calculations (total === 0 ? 0 : Math.round(...)) designed to preventNaNor zero division errors when computing ratios likeweekendRatio.This refactor bundles this pattern into a robust
calculateSafePercentage()utility function, improving codebase maintainability and readability.Changes
lib/calculate.tscalculateSafePercentage()helper and replaced redundant inline ternaries.lib/calculate.test.tsChecklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors.