fix(themes): normalize theme query parameter lookup to make theme selection case-insensitive#6146
Open
ChetanSenta wants to merge 1 commit into
Open
Conversation
Contributor
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod-Dev
approved these changes
Jun 21, 2026
Aamod-Dev
left a comment
Collaborator
There was a problem hiding this comment.
Excellent fix to improve user experience. Normalizing the theme query parameter using getNormalizedThemeKey in lib/svg/themes.ts prevents unnecessary fallbacks when users make minor casing typos. The logic in app/api/streak/route.ts elegantly integrates this helper. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6143
Pillar
Visual Preview
No visual changes to the themes themselves. However, passing parameters like
?theme=CYANPULSEor?theme=cyanpulsewill now correctly load thecyanPulsetheme style instead of crashing or breaking back to an unstyled fallback default state.What this PR does
Previously, the incoming
themequery parameter string was matched exactly against keys of theTHEMESobject. This meant strict case sensitivity was expected from end-users (cyanPulseworked, butcyanpulseor uppercase equivalents failed).This PR introduces a
getNormalizedThemeKey()utility insidelib/svg/themes.tsto scan and safely match theme names case-insensitively.Changes
lib/svg/themes.tsgetNormalizedThemeKey()case-insensitive lookup helper.app/api/streak/route.tslib/svg/themes.test.tsChecklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors.