Feat/cherry blossom reduced motion#6140
Closed
aisshwaryaa8-collab wants to merge 2 commits into
Closed
Conversation
Contributor
|
@aisshwaryaa8-collab is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
👋 Hey @aisshwaryaa8-collab! Thanks for your interest in contributing to CommitPulse! 🙏 Unfortunately, this PR has been automatically closed because you are not assigned to the linked issue #6139 — feat: Respect prefers-reduced-motion for CherryBlossom background animation. To avoid this in the future, please follow these steps:
We look forward to your contribution once you're assigned! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CherryBlossom renders 25 falling petals on an infinite (repeat: Infinity) loop across the full viewport, with no way for the user to opt out. This adds a check using framer-motion's useReducedMotion() hook — if the user has prefers-reduced-motion: reduce set at the OS level, the component now returns null instead of forcing the animation on them. This aligns with WCAG 2.3.3 guidance on perpetual background motion.
Also updated the existing framer-motion mocks across 7 other CherryBlossom.*.test.tsx files to include useReducedMotion, since they previously only mocked motion.div and broke once the component started calling the new hook. Added 2 new tests to CherryBlossom.test.tsx covering both the reduced-motion and normal-motion paths.
Fixes #6139 6139
Pillar
Visual Preview
None
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.