Skip to content

fix: External image fallback may not work reliably because it overwrites src without guarding#6022

Open
Aditya8369 wants to merge 6 commits into
JhaSourav07:mainfrom
Aditya8369:3607
Open

fix: External image fallback may not work reliably because it overwrites src without guarding#6022
Aditya8369 wants to merge 6 commits into
JhaSourav07:mainfrom
Aditya8369:3607

Conversation

@Aditya8369

Copy link
Copy Markdown
Contributor

closes #3607

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@Aditya8369 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @Aditya8369, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@github-actions github-actions Bot added the type:bug Something isn't working as expected label Jun 19, 2026
@Aamod-Dev Aamod-Dev added level:intermediate Moderate complexity tasks quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. mentor:Aamod007 labels Jun 20, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Aditya8369, this PR has a status:blocked label so I can't approve it for now. The onError fallback pattern looks good across all 7 components — CompareClient.tsx, LandingPageClient.tsx, ContributorsSearch.tsx, CommitPulseSection.tsx, Leaderboard.tsx, GithubWrapped.tsx, HallOfFame.tsx, and ProfileCard.tsx. The guard checking arget.src !== 'https://github.com/github.png' prevents infinite loops. Once the block is cleared, I'll be happy to re-review!

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

This PR cannot be approved in its current state due to blocking issues (status:blocked label, merge conflicts, needs-rebase label, and/or failing CI checks). Please resolve the blocking issues and re-request review.

Once unblocked, I'm happy to re-review! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. status:blocked This PR is blocked due to a failing CI check. type:bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: External image fallback may not work reliably because it overwrites src without guarding

2 participants