fix(reviewform): route wall of love testimonial submissions#5973
fix(reviewform): route wall of love testimonial submissions#5973NayansiDupare wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@NayansiDupare is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff3d39c9ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // ── Types ───────────────────────────────────────────────────────────────────── | ||
| type Platform = 'twitter' | 'github'; | ||
| const TESTIMONIAL_ISSUE_URL = 'https://github.com/JhaSourav07/commitpulse/issues/new'; |
There was a problem hiding this comment.
When a normal visitor submits this new form, it redirects to GitHub's blank issue URL, but this repo has blank issues disabled in .github/ISSUE_TEMPLATE/config.yml:1 and only bug/feature issue forms are available. That means the prefilled testimonial title/body cannot be submitted as intended; users are sent to the issue-template chooser/blocked blank issue flow instead. Point this URL at an allowed testimonial template or re-enable blank issues before routing submissions this way.
Useful? React with 👍 / 👎.
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
Aamod-Dev
added
level:intermediate
Aamod-Dev
left a comment
Aamod-Dev
left a comment
There was a problem hiding this comment.
Good fix for the /reviewform route in �pp/reviewform/page.tsx - replaces broken API-submission form with a working GitHub-issue-based submission flow. Refactors from complex client-side state management to a clean �uildTestimonialIssueUrl function. Adds proper test coverage in �pp/reviewform/page.test.tsx and updates components/WallOfLove.test.tsx. Good intermediate-level bug fix.
Aamod-Dev
left a comment
Aamod-Dev
left a comment
There was a problem hiding this comment.
Review
This PR cannot be approved in its current state due to blocking issues (status:blocked label, merge conflicts, needs-rebase label, and/or failing CI checks). Please resolve the blocking issues and re-request review.
Once unblocked, I'm happy to re-review! 💚
3 participants
Description
##profram-gssoc26
Fixes #5907
Added a working
/reviewformroute for the Wall of Love section so users no longer get a 404 after clicking Share Your Experience. The new page lets users submit testimonial details through a prefilled GitHub issue flow for maintainer review.Pillar
Visual Preview
Not applicable; this fixes a homepage CTA route and testimonial submission page, not SVG output.
Test plan
npm run lintnpm run format:checknpm run test -- "components/WallOfLove.test.tsx" "app/reviewform/page.test.tsx"Note: Full
npm run testwas attempted, but unrelatedapp/components/navbar.test.tsxtests stalled with jsdom navigation timeout warnings before completing.