[Plugin Protocol] Make BaseBuildPlugin generic with the Context Type#176
Open
JulienArzul wants to merge 1 commit intomainfrom
Open
[Plugin Protocol] Make BaseBuildPlugin generic with the Context Type#176JulienArzul wants to merge 1 commit intomainfrom
JulienArzul wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
The change is trying to help the plugins type themselves better and avoid errors due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Since we now know the context_type, this PR actually uses it in the Plugin's protocol, so that all the methods can return the right type.
e.g: the declared
context_typeis now the type returned bybuild_context