-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add null object pattern #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
benchmarks/PatternKit.Benchmarks/Behavioral/NullObjectBenchmarks.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| using BenchmarkDotNet.Attributes; | ||
| using PatternKit.Behavioral.NullObject; | ||
| using PatternKit.Generators.NullObject; | ||
|
|
||
| namespace PatternKit.Benchmarks.Behavioral; | ||
|
|
||
| [BenchmarkCategory("Behavioral", "NullObject")] | ||
| public class NullObjectBenchmarks | ||
| { | ||
| private static readonly Notification Notification = new("C-100", "Statement ready"); | ||
|
|
||
| [Benchmark(Baseline = true, Description = "Fluent: create null object")] | ||
| [BenchmarkCategory("Fluent", "Construction")] | ||
| public NullObject<INullNotificationChannel> Fluent_CreateNullObject() | ||
| => NullObject<INullNotificationChannel> | ||
| .Create(NullNotificationChannel.Instance) | ||
| .Build(); | ||
|
|
||
| [Benchmark(Description = "Generated: get null object instance")] | ||
| [BenchmarkCategory("Generated", "Construction")] | ||
| public INullNotificationChannel Generated_GetInstance() | ||
| => NullNotificationChannel.Instance; | ||
|
|
||
| [Benchmark(Description = "Fluent: invoke null object")] | ||
| [BenchmarkCategory("Fluent", "Execution")] | ||
| public string Fluent_Invoke() | ||
| => Fluent_CreateNullObject().Instance.Send(Notification); | ||
|
|
||
| [Benchmark(Description = "Generated: invoke null object")] | ||
| [BenchmarkCategory("Generated", "Execution")] | ||
| public string Generated_Invoke() | ||
| => NullNotificationChannel.Instance.Send(Notification); | ||
| } | ||
|
|
||
| public sealed record Notification(string CustomerId, string Subject); | ||
|
|
||
| [GenerateNullObject(TypeName = "NullNotificationChannel")] | ||
| public interface INullNotificationChannel | ||
| { | ||
| [NullObjectDefault("suppressed")] | ||
| string Send(Notification notification); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # Null Object Notification Example | ||
|
JerrettDavis marked this conversation as resolved.
|
||
|
|
||
| The customer notification example shows how to keep a workflow production-safe when an optional notification provider is not configured. | ||
|
|
||
| The generated `NullCustomerNotificationChannel` implements `ICustomerNotificationChannel` and returns a deterministic `"suppressed"` status. The fluent `NullObject<ICustomerNotificationChannel>` wrapper is registered through `IServiceCollection` so importing applications can inject the fallback channel without special-case `null` logic. | ||
|
|
||
| Relevant files: | ||
|
|
||
| - `src/PatternKit.Examples/NullObjectDemo/CustomerNotificationNullObjectDemo.cs` | ||
| - `test/PatternKit.Examples.Tests/NullObjectDemo/CustomerNotificationNullObjectDemoTests.cs` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Null Object Generator | ||
|
JerrettDavis marked this conversation as resolved.
|
||
|
|
||
| `[GenerateNullObject]` generates a sealed Null Object implementation for an interface contract. | ||
|
|
||
| ```csharp | ||
| [GenerateNullObject(TypeName = "NullInventoryNotifier")] | ||
| public interface IInventoryNotifier | ||
| { | ||
| [NullObjectDefault(false)] | ||
| bool CanDeliver { get; } | ||
|
|
||
| [NullObjectDefault("suppressed")] | ||
| string Notify(string sku); | ||
| } | ||
| ``` | ||
|
|
||
| Generated output includes: | ||
|
|
||
| - a sealed implementation of the contract | ||
| - a static `Instance` property | ||
| - no-op `void` methods | ||
| - deterministic defaults for strings, booleans, numeric values, arrays, `Task`, `Task<T>`, `ValueTask`, and `ValueTask<T>` | ||
| - per-member defaults through `[NullObjectDefault]` | ||
|
|
||
| Use the generated implementation directly or wrap it with `NullObject<TContract>` for consistent dependency injection registration. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.