Add opt-in visual discovery and editorial ranking (v0.13.0) - #76
Merged
Merged
Conversation
JeremySNR
marked this pull request as ready for review
September 25, 2026 19:09
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Coarse scan schema allows invalid frames
- Parameterized the proposal JSON schema on times.length so coarse scans advertise max frame index 7 instead of 9.
You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit dd40224. Configure here.
The shared proposal JSON schema always used framesPerRefinement-1, so coarse scans (8 frames) could advertise invalid indices 8–9 and then fail validateProposal for the whole window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this change?
Adds opt-in visual moment discovery and independent editorial ranking, with honest uncertainty and source evidence in the editor. Prepares v0.13.0 and adds an offline benchmark workflow for comparing the old and new selections through blind human review.
Why?
Transcript-only discovery misses demonstrations and reveals. The previous ranking could reward generated packaging without checking that the retained source delivered a complete, understandable clip. These stages inspect source frames, retained speech and surrounding context; uncertain reviews remain visible instead of receiving a confident score.
Release notes
How did you test it?
docs/provider-smoke.md.705fcfe): Linux tests, offline FFmpeg pipeline, GUI smoke, release notes, packaged Apple Silicon inference/export, and automatic code review.Anything to watch out for?
Both features are opt-in betas with bounded extra analysis calls. Sparse sampled frames can miss short events. Scores are editorial assessments, not viral probabilities. Automated regressions do not establish human preference or superiority over OpusClip; the documented holdout comparison is still required.
The user approved releasing after ChatGPT validation and CI, with the API route explicitly recorded as not live-tested because no API key is configured here. No dependency changes are introduced.