fix(install): prevent unbound variable error on EXIT trap#25
Merged
Conversation
When install.sh is piped to bash (curl | bash), the EXIT trap fires after main() returns. Since tmpdir was declared local, it was destroyed when main() exited, causing 'tmpdir: unbound variable' under set -u. The binary installed successfully, but the script exited with code 1. Fix by making tmpdir a global variable so the trap can reference it after main() returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
When the install script is piped to bash via
curl -fsSL ... | bash, it reports a spurious error at the end:The binary actually installs successfully to
~/.local/bin/tick, but the non-zero exit code is confusing and may break automation.Root Cause
tmpdirwas declared as alocalvariable insidemain(). TheEXITtrap references it, but aftermain()returns the local variable is destroyed. Underset -uthis triggers an unbound variable error when the trap fires during script teardown.Fix
Make
tmpdira global variable so theEXITtrap can safely reference it aftermain()returns.Verification
unbound variable