Archaic design doc: record the shipped state and where it diverged from the plan - #37
Merged
Merged
Conversation
…om the plan The doc's header still read "No code yet" for a feature that shipped in v0.1.0-alpha.14, M3 was headed "in progress" after M3.3 wired it end to end, and §9's open questions were headed "Still open before Phase 1" with all three long since closed. Corrected, and §8 now carries per-phase status. The staleness was the easy half. Three things shipped DIFFERENTLY from §10 and none was recorded where the plan states the rule, so a reader following the document would have been misled about what the code does: - M3 mandates a feature gate over Tier B covering the read AND publish paths. No such constant exists. Extent shipped ungated; only lineage attribution is gated. Defensible -- the fabrication risk the gate existed to contain was entirely in attribution -- but the plan still read as if the gate were there. - §7's "~1.5-2% Neanderthal" is not the target the caller was calibrated against. Three denominators are in play (whole genome, callable genome, hmmix's per-haplotype union) and they are not interchangeable: the shipped claim is 91.5 Mb against hmmix's measured EUR mean of 90.9 Mb, which is 1.01x. Quoting §7's figure next to the shipped 5.04% compares two different measurements, so §7 now says so in place. - M3 requires a test asserting "none reliably detected" for the Denisovan floor. It was never written. Shipped behaviour is stronger (Denisovan is never surfaced at all), but nothing currently FAILS if a future change starts emitting denisovan_copies as a headline. That is an open gap, not a deviation that resolved itself, and it is recorded as one. Adds a "Deviations from the plan" section carrying those three with their justification and their residual risk -- extent is fitted on ONE individual, so its error is uncharacterised for anyone with unusual ancestry or coverage. Plus an open-follow-ups list: the missing test, multi-individual validation, the Skov-2020 attribution upgrade, and the asset-staging decision. That last one is a live defect rather than a doc bug. M1 said to check Asset 1's size against ON_DEMAND_PREFIXES "before deciding" and no decision was ever made, so PATTERNS lists no archaic_* while release mode bundles all five (105.3 MB) -- the two staging modes disagree, and alpha.14's installers are ~60 MB larger than alpha.13's. Recorded here; fixed separately. Documentation only; no code changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-ship audit of
documents/design/ArchaicAncestry_Design.md. Documentation only — no code changes.Staleness
The doc's header read "No code yet" for a feature that shipped in
v0.1.0-alpha.14. Also fixed: M3 was headed "in progress" after M3.3 wired it end to end, §9's questions were under "Still open before Phase 1" with all three long closed, and §8's phases carried no status.The part that actually mattered
Three things shipped differently from §10, and none was recorded at the point where the plan states the rule — so a reader following this document would have been misled about what the code does.
attribute_lineageis offEach is annotated in place with a blockquote, so the rule and its reality sit together, plus a new Deviations from the plan section carrying the justification and the residual risk.
The honest read on each:
denisovan_copiesas a headline.Residual risk now stated rather than implied: extent is fitted on one individual, so its error is uncharacterised for anyone with unusual ancestry or coverage.
Open follow-ups (new section)
The staging defect, recorded here and fixed separately
M1 said to check Asset 1's size against
ON_DEMAND_PREFIXESinpackaging/stage-assets.sh"before deciding". No decision was ever made, soPATTERNSlists noarchaic_*while release mode fetches everything the manifest names exceptancestry_haps_— bundling all five archaic assets (105.3 MB). The two staging modes disagree, which is precisely what the comment abovePATTERNSwarns against.Measured: alpha.14's installers are ~60 MB larger than alpha.13's (
.dmg136→199 MB,.exe105→163 MB). Fixed in a follow-up PR.🤖 Generated with Claude Code