fix(git): validate submodule push exit status and warn on detached HEAD - #2
Open
lucienve wants to merge 1 commit into
Open
fix(git): validate submodule push exit status and warn on detached HEAD#2lucienve wants to merge 1 commit into
lucienve wants to merge 1 commit into
Conversation
Check the return code of `git push origin` in `commitChanges` to ensure submodule commits are successfully pushed before parent repository updates. If the push fails, check for detached HEAD state and throw an error to prevent unpushed submodule commit pointers from corrupting parent repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the return code of
git push originincommitChangesto ensure submodule commits are successfully pushed before parent repository updates. If the push fails, check for detached HEAD state and throw an error to prevent unpushed submodule commit pointers from corrupting parent repositories.Fixes #1