Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR adds inline comments to a few service methods/classes to clarify intent and behavior across the webhook, sampledata, and delivery modules.
Changes:
- Document event ordering/mapping behavior in
EventService#findAllEvents. - Explain why sample data seeding logic is centralized in
SampleDataService#createSampleData. - Add a brief note explaining why
DeliveryServiceis intentionally minimal.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| webhook/src/main/java/com/yas/webhook/service/EventService.java | Adds a short comment describing the sort order and mapping to view models. |
| sampledata/src/main/java/com/yas/sampledata/service/SampleDataService.java | Adds a comment explaining the rationale for keeping seeding in one place. |
| delivery/src/main/java/com/yas/delivery/service/DeliveryService.java | Adds a comment explaining why the service is minimal (but currently introduces a tab). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| @Service | ||
| public class DeliveryService { | ||
| // Intentionally left minimal for Spring wiring and CI coverage. |
|
…ice, and EventService
vt-Toan
approved these changes
May 2, 2026
Toanapr
approved these changes
May 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.