Repository navigation
add resolve_address() method to client objects - #30
Merged
Merged
Conversation
Parses various input overloads such as 'client-name:port_name',
('client-name','port-name), etc., returns Address. Raises exception
if Address(client_id, port_id) doesn't exist. Added new fd() public
accessor. Added tests/test_sequencer_address.py. Modified
examples/connect.py to accept 'client-name:port-name'.
Parses various input overloads such as 'client-name:port_name',
('client-name','port-name'), etc., returns Address. Raises exception
if Address(client_id, port_id) doesn't exist. Added new fd public
getter. Added tests/test_sequencer_address.py. Modified
examples/connect.py to accept 'client-name:port-name'
Update:
- Changed get_address() to resolve_address()
- Added @Property to fd() to make read-only fd
- Fixed test_sequencer_address.py to run under tox/pytest
- Changed whitespace,etc to pass tox style/flake8, except
in test_sequencer_address.py
Parses various input overloads such as 'client-name:port_name',
('client-name','port-name'), etc., returns Address. Raises exception
if Address(client_id, port_id) doesn't exist. Added new fd public
getter. Added tests/test_sequencer_address.py. Modified
examples/connect.py to accept 'client-name:port-name'
Update:
- Changed get_address() to resolve_address()
- Added @Property to fd() to make read-only fd
- Fixed test_sequencer_address.py to run under tox/pytest
- Changed whitespace,etc to pass tox style/flake8, except
in test_sequencer_address.py
Update:
- Whitespace/indentation changes, directives, and exclusions
for for tox/pytest/isort.
- All tests pass without error.
client: add resolve_address() and fileno()
Parses various input overloads such as 'client-name:port_name',
('client-name','port-name'), etc., returns Address. Raises exception
if Address(client_id, port_id) doesn't exist. Added new fileno()
public accessor. Added tests/test_sequencer_address.py. Modified
examples/connect.py to accept 'client-name:port-name'
Update:
- Changed get_address() to resolve_address()
- Added @Property to fd() to make read-only fd
- Fixed test_sequencer_address.py to run under tox/pytest
- Changed whitespace,etc to pass tox style/flake8, except
in test_sequencer_address.py
Update:
- Whitespace/indentation changes, directives, and exclusions
for for tox/pytest/isort.
- All tests pass without error.
Update:
client.py:
- Removed "@Property\ndef fd(self):"
- Replaced with Jajcus-provided "fileno(self)"
- Removed typo/bug, redesigned/rewrote argument validation in resolve_address()
- Fixed typo introduced in docstring
test_sequencer_address.py
- Fixed bug, use of non-existent variable
- Removed unused variable
- Removed "# flake8: noqa"
- Reformatted code with autopep8
- Moved file-level docstring to top of file
- Added "import pytest" and "@pytest.mark.require_alsa_seq"
- Added more "# isort: skip" (imports in correct order, still produce errors)
- Added "# noqua: F824" (global variables *are* used, flake8 flags incorrectly)
tox.ini
- Removed "-exclude = tests/test_sequencer_address.py"
Use '|' instead of Union[]
Jajcus
force-pushed
the
address_port_string
branch
from
October 21, 2026 15:55
3547441 to
a3ed4a7
Compare
not only Address but Port and PortInfo too, as the method signature says
Jajcus
force-pushed
the
address_port_string
branch
from
October 21, 2026 16:15
a3ed4a7 to
b16554b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #27 by @thanks4opensource, just rebased and with two minor fixes added.
See the original MR for more information and discussion.