fix(engine): add minRankAutotuneEnabled to the policy-spec dist-twin test's full-shape pin#8283
Conversation
…test's full-shape pin #8270 added the field to AmsPolicySpec and updated the ROOT vitest twin's pin but missed this node:test dist twin — the engine workspace suite has been red on main since (masked in #8270's own local gate run, which short-circuited at an unrelated coverage-phase timeout before reaching the workspace suites). Test-only; the engine suite passes 0-not-ok with it.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8283 +/- ##
==========================================
- Coverage 92.16% 92.16% -0.01%
==========================================
Files 788 788
Lines 79175 79175
Branches 23933 23933
==========================================
- Hits 72974 72970 -4
Misses 5062 5062
- Partials 1139 1143 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-23 23:42:40 UTC
Review summary Nits — 1 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
#8270 added
minRankAutotuneEnabledtoAmsPolicySpecand updated the root vitest twin's full-shape pin, but missed this node:test dist twin — the engine workspace suite has been red on main since. Test-only, one line; the full engine suite passes with it (0not ok). Caught by the next branch's full gate; fixing forward immediately per the fix-discovered-drift convention.Validation
npm run test --workspace @loopover/engineexit 0, zero failures.