test(calibration): invariant — live capture confidence varies with finding inputs#8260
Merged
Merged
Conversation
…nding inputs (#8243 follow-up) The historical ledger's decision layer stamped a constant 1.0 on every close while 38% reversed. The live capture writers are the corpus the armed loops now act on, so this pins that their confidence axis is real: three findings with three confidences must record three distinct values, byte-for-byte. A regression to constant-confidence capture — the exact failure mode #8243 documented — can no longer land silently. Honors the surviving requirement from #8243's reconciled scope (the gate review on its closing PR correctly noted the literal scope had been reframed; this is the piece that still applied, pointed at the live path).
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8260 +/- ##
==========================================
- Coverage 92.14% 91.61% -0.53%
==========================================
Files 785 785
Lines 78715 78715
Branches 23759 23759
==========================================
- Hits 72531 72116 -415
- Misses 5062 5524 +462
+ Partials 1122 1075 -47
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only follow-up honoring #8243's surviving requirement, per the scope reconciliation recorded on the issue: the gate review on its closing PR correctly noted the literal scope (fix a live constant-1.0 writer) had been reframed after the investigation disproved its premise — the constant came from the retired legacy pipeline. The requirement that still applied is the invariant test, pointed at the live path: three findings with three different confidences must record three distinct values through
recordConfiguredGateBlockerSignals, so a regression to constant-confidence capture — the exact failure mode that blinded the historical decision layer while 38% of its closes reversed — can never land silently again.Suite green (22/22). No src changes.
Advances #8243