Navigation rail in landscape - #87
Merged
Merged
Conversation
tekstrand
marked this pull request as draft
August 28, 2026 17:44
…e main activity layout puts a NavigationRailView on the left edge, so landscape spends horizontal space on navigation and keeps the short screen for content instead of losing a strip to a full-width bottom bar. Portrait keeps the bottom bar, which now always shows its labels via labelVisibilityMode. The activity and fragments reference the nav view as NavigationBarView, the superclass both widgets share, so the same code drives either one. The five tabs switch from the android system icons to local Material Symbols drawables, tinted from the theme. Decodes gets a new ic_notes: the tab is merged into Monitor by upcoming work, so the final set never drew an icon for it.
tekstrand
force-pushed
the
navigation-rail
branch
from
August 28, 2026 17:45
bbe9f42 to
e90a2ed
Compare
tekstrand
marked this pull request as ready for review
August 28, 2026 17:49
Contributor
|
This one looks great, I'm going to hold onto it for a short bit as I'm going to try and push out a 1.0 release this week. After that I'll start pulling in changes that target UI upgrades and such like we've been discussing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Test
./gradlew :app:testDebugUnitTest./gradlew :app:assembleDebuginstalled on Fire HD 10 and Pixel 7 profile emulators. Landscape shows the rail on the left, portrait shows the labeled bottom bar, and tab switching works in both.Screenshots
Tablet
Phone