Skip to content

Simulating symfony/symfony#5401#359

Open
JMSBot wants to merge 1 commit into
symfony-symfony-5401-before-50409277e5bf0from
symfony-symfony-5401-after-504092796776c
Open

Simulating symfony/symfony#5401#359
JMSBot wants to merge 1 commit into
symfony-symfony-5401-before-50409277e5bf0from
symfony-symfony-5401-after-504092796776c

Conversation

@JMSBot

@JMSBot JMSBot commented Aug 31, 2012

Copy link
Copy Markdown
Owner

Original Pull Request: #5401 on symfony/symfony
Used Engine Version: e445afba607d8f00ed1ade966348d5ad05c7d33e (2012-08-30 06:47)
Review Details: http://jmsyst.com/reviews/116f8fdc-e0fc-4303-957c-f257cb010994

@JMSBot

JMSBot commented Aug 31, 2012

Copy link
Copy Markdown
Owner Author

I have also comments on lines which were not directly changed by the pull request, but which seem nonetheless be affected by your proposed changes:

  • src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
    • Line 76: Are you sure that the property "message" exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant