Repository navigation
refactor(investing): migrate Magic Formula into investing/ (#181) - #185
Merged
Merged
Conversation
Mirror credit layout: investing/{CONTEXT.md,docs/,src/investing/,apps/,tests/}.
Hard-rename package smartwealthai → investing (no shim). Move docs/mvp →
investing/docs, dashboard → investing/apps/dashboard, and tests/credit →
credit/tests. Update Poetry entry points, CI, AGENTS, CONTEXT-MAP, and cursor
rules so the demo pipeline stays green under Poetry.
Co-authored-by: jdlsicilia <jdlsicilia@gmail.com>
|
Important Review skippedToo many files! This PR contains 116 files, which is 16 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters: 13
📒 Files selected for processing: 116
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #185 +/- ##
===========================================
+ Coverage 98.71% 99.02% +0.31%
===========================================
Files 40 64 +24
Lines 2566 5355 +2789
Branches 309 321 +12
===========================================
+ Hits 2533 5303 +2770
- Misses 25 44 +19
Partials 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JLaborda
marked this pull request as ready for review
October 14, 2026 10:32
Contributor
|
@coderabbitai review |
Owner
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 89e6045. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR1 of epic #180 — migrate Magic Formula into a
credit/-mirroredinvesting/tree and hard-rename the Python packagesmartwealthai→investing(no shim).Closes #181.
Layout
src/smartwealthai/investing/src/investing/CONTEXT.mdinvesting/CONTEXT.mddocs/mvp/investing/docs/apps/dashboard/investing/apps/dashboard/tests/investing/tests/tests/credit/credit/tests/Root
CONTEXT-MAP.mdanddocs/adr/stay at repo root (updated paths).Tooling
investingfrominvesting/src,creditfromcredit/src--cov=investing), Makefile updatedOut of scope
uv workspace, domain deps split, CI matrix, Spec Kit, credit features, unified portal.
Test plan
make lintpoetry run pytest --cov=investing --cov=credit --cov-branch→ 333 passed