Seating: a plus-one follows their guest into a family, and out of it - #95
Merged
Merged
Conversation
…of it Adding a guest to a family left the person they bring behind, so every couple had to be added one at a time and a plus-one could end up split from their guest. The plus-one now comes too, in the same command, so one undo puts both back. Taking the guest out of the family takes their plus-one with them. A plus-one someone deliberately put in a different family stays there. Closes #62 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VhFp1PtVBwgmxST9ZrRTEs
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62
What a user would notice
plusOneOf) joins too.How
plusOnesWith(plan, guest): the guests whoseplusOneOfis this guest and who are in the same family as them (or, like them, in none).addToFamilymoves the guest and those plus-ones in a single command. Each move reads what the previous one wrote (family(),subgroup(),group()), so moving two people out of the same old family keeps both removals.removeFromFamilytakes the same set out together.Dragging several selected guests onto a family still calls
addToFamilyonce per guest. If both a guest and their plus-one are selected, the second call is a no-op on membership.Checks
store/organise.test.ts: follows in; follows from one family to another; stays in a different family; leaves with their guest. Three failed onmain; the "stays" case passed onmainand still does. All pass now.🤖 Generated with Claude Code
https://claude.ai/code/session_01VhFp1PtVBwgmxST9ZrRTEs
Generated by Claude Code