Seating: searching a family or subgroup by name finds its members - #94
Merged
Merged
Conversation
The guest panel's search compared each guest with their own names and the top-level group's name only. A family sits inside a subgroup inside a group in any real plan, so searching "The Engines" found nobody unless one of them happened to share the name. Search now matches the names of the group, subgroup and family each guest is in, the same way at every level of the list. Closes #57 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VhFp1PtVBwgmxST9ZrRTEs
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57
What a user would notice
Typing a family's or subgroup's name in Seating's guest search now shows its members. Before, only a personal name or the top-level group's name matched. A family in a real plan sits inside a subgroup inside a group, so this was the normal case.
Cause, with evidence
GuestPanelpassedmatchesSearchthe top-level group only. The new component test showed exactly that split onmain: searching by family name and by subgroup name failed, while group-name and personal-name searches passed.Fix
matchesSearch(guest, containerNames, query)now takes the names of the group, subgroup and family the guest is in.GuestPanelbuilds those from the guest's own ids, in oneshown()predicate used at all three levels of the list (grouped, standalone families, ungrouped), so every level behaves the same.Checks
GuestPanel.test.tsx: family name, subgroup name, group name, personal name. The first two failed onmain; all four pass now.🤖 Generated with Claude Code
https://claude.ai/code/session_01VhFp1PtVBwgmxST9ZrRTEs
Generated by Claude Code